Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoroughly test FractionInputIsEquivalentToAndInSimplestFormRuleClassifier #1890

Closed
Sarthak2601 opened this issue Sep 24, 2020 · 2 comments · Fixed by #2222
Closed

Thoroughly test FractionInputIsEquivalentToAndInSimplestFormRuleClassifier #1890

Sarthak2601 opened this issue Sep 24, 2020 · 2 comments · Fixed by #2222
Assignees
@jcqli
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 24, 2020 •
edited by rt4914
Loading

Since the FractionInputIsEquivalentToAndInSimplestFormRuleClassifier was copied from Oppia web, it didn't have corresponding tests added to verify correctness. These should be ported over from Oppia web as well to ensure that each classifier has working functionality.

Useful reference - https://github.com/oppia/oppia-android/tree/develop/domain/src/test/java/org/oppia/android/domain/classify/rules
@Sarthak2601 Sarthak2601 added Type: Improvement Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. good first issue This item is good for new contributors to make their pull request. labels Sep 24, 2020
@Sarthak2601 Sarthak2601 added this to the Backlog milestone Sep 24, 2020
@Sarthak2601 Sarthak2601 mentioned this issue Sep 24, 2020
Closed
29 tasks
@BenHenning BenHenning added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2020
@Florence-Njeri Florence-Njeri removed their assignment Nov 4, 2020
@jcqli
Copy link
Contributor

jcqli commented Nov 30, 2020

I'd like to work on this, thanks!

@BenHenning BenHenning assigned BenHenning and jcqli and unassigned BenHenning Nov 30, 2020
@BenHenning
Copy link
Member

Done @jcqli (fyi @anandwana001).

@BenHenning BenHenning removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Dec 3, 2020
@jcqli jcqli mentioned this issue Dec 4, 2020
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Dec 16, 2020
@jcqli
Fix #1890: Add tests for FractionInputIsEquivalentToAndInSimplestForm…
05ccbc9 
…RuleClassifierProvider (#2222)

* Add tests for FractionInputIsEquivalentToAndInSimplestFormRuleClassifierProvider

* Add test to check that equal but not simplest form is false

* Fix linter issues

* Specify Truth.assertThat import

* Add test case for correct input / answer types

* Add test to bazel build

* Fix typo, add FractionInput tests to bazel build

* Resolve merge conflicts
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcqli jcqli

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
5 participants
@BenHenning @anandwana001 @jcqli @Florence-Njeri @Sarthak2601