Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProfileChooserFragmentTest for Robolectric #1871

Closed
Sarthak2601 opened this issue Sep 23, 2020 · 0 comments · Fixed by #2045
Closed

Fix ProfileChooserFragmentTest for Robolectric #1871

Sarthak2601 opened this issue Sep 23, 2020 · 0 comments · Fixed by #2045
Assignees
@anandwana001
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 23, 2020 •
edited
Loading

Currently, the app module test cases in ProfileChooserFragmentTest are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.
@Sarthak2601 Sarthak2601 added Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Sep 23, 2020
@Sarthak2601 Sarthak2601 added this to the Beta milestone Sep 23, 2020
@Sarthak2601 Sarthak2601 changed the title Fix app module tests in profile for Robolectric Fix ProfileChooserFragmentTest for Robolectric Sep 24, 2020
@rt4914 rt4914 mentioned this issue Sep 24, 2020
Closed
24 tasks
@anandwana001 anandwana001 mentioned this issue Oct 26, 2020
Merged
8 tasks
@anandwana001 anandwana001 self-assigned this Oct 26, 2020
@anandwana001 anandwana001 mentioned this issue Nov 23, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Nov 23, 2020
@anandwana001
Fix part of #1871: Fix span test of ProfileChooserFragmentTest (#2157)
f2e4436 
* fix span test of ProfileChooserFragmentTest

* nit fix
anandwana001 added a commit that referenced this issue Dec 7, 2020
@anandwana001
Fix #1871: Fix ProfileChooserFragmentTest for Robolectric (#2045)
893f017 
* fix ProfileChooserFragmentTest for robolectric test

* nit fix

* removed e2e test, shifted to other issue

* shift span test to ProfileChooserSpanTest

* undo gradle.xml

* make tests more readable

* added observer in profile test helper

* nit fix

* fix 2 test case

* kdocs formatting

* fix kdocs

* kdocs fix
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anandwana001 anandwana001

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1871: Fix ProfileChooserFragmentTest for Robolectric anandwana001/oppia-android
3 participants
@BenHenning @anandwana001 @Sarthak2601