-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images are failing to load sometimes in the exploration player #1781
Comments
@rt4914 found that UrlImageParser is posting a layout adjustment function for width that's racing against the layout steps in wrap_content cases which can result in a negative maximum image width being computed. Per our discussion, we should force text views in Oppia Android that use HtmlParser to specify a width or use match_parent. It's not yet clear if updating those text views will fix this issue, but it seems likely. Sending over to Rajat to see if this gets fixed with his solution. |
Putting this video link here for issue reference - https://lh3.googleusercontent.com/Pp2LOc-FuR5ZvsxcEQ8Tt9Ikpqnp_TiQiGH0unuY2tCD54gXumCT4Sp3tK0SjVHefVruXSeSLcUwEJ4=m37 |
Ah, this might be slightly better with #1782 done, but I also realized that we're missing some caching logic for multiple choice options which is causing this to fail for offline cases. One PR should be coming for that. |
* Introduce hacky workaround for AOSP bug where image-only HTML isn't rendered correctly. * Remove unused line & lint fix.
See #1637 (comment) for specifics. More investigation is needed.
How to encounter this error?
MRJeVrKafW6G.json
file and change "init_state_name" toRecap 1
5. Multiplying by power of 10
Expected Result
This image should be visible in hint. https://storage.googleapis.com/oppiaserver-resources/exploration/MRJeVrKafW6G/assets/image/img_20200308_213016_u6ap4qq25c_height_313_width_490.png
The text was updated successfully, but these errors were encountered: