Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are failing to load sometimes in the exploration player #1781

Closed
BenHenning opened this issue Sep 3, 2020 · 3 comments · Fixed by #1797 or #1798
Closed

Images are failing to load sometimes in the exploration player #1781

BenHenning opened this issue Sep 3, 2020 · 3 comments · Fixed by #1797 or #1798
Assignees
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 3, 2020

See #1637 (comment) for specifics. More investigation is needed.

How to encounter this error?

  1. Using the scripts load the oppia-alpha assets.
  2. Uninstall your previous app.
  3. Go to MRJeVrKafW6G.json file and change "init_state_name" to Recap 1
  4. Using this function mark dummy progress.
  5. Run the app.
  6. Go to Multiplications
  7. Go to 5. Multiplying by power of 10
  8. Enter 2 incorrect answer.
  9. Click on hint -> reveal.
  10. Notice it is empty.

Expected Result
This image should be visible in hint. https://storage.googleapis.com/oppiaserver-resources/exploration/MRJeVrKafW6G/assets/image/img_20200308_213016_u6ap4qq25c_height_313_width_490.png

@BenHenning BenHenning added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Sep 3, 2020
@BenHenning BenHenning added this to the Alpha milestone Sep 3, 2020
@BenHenning
Copy link
Member Author

@rt4914 found that UrlImageParser is posting a layout adjustment function for width that's racing against the layout steps in wrap_content cases which can result in a negative maximum image width being computed. Per our discussion, we should force text views in Oppia Android that use HtmlParser to specify a width or use match_parent. It's not yet clear if updating those text views will fix this issue, but it seems likely. Sending over to Rajat to see if this gets fixed with his solution.

@BenHenning BenHenning assigned rt4914 and BenHenning and unassigned rt4914 Sep 4, 2020
@anandwana001
Copy link
Contributor

@BenHenning
Copy link
Member Author

Ah, this might be slightly better with #1782 done, but I also realized that we're missing some caching logic for multiple choice options which is causing this to fail for offline cases. One PR should be coming for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
3 participants