Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Structure: ConceptCardFragment #160

Closed
BenHenning opened this issue Sep 20, 2019 · 2 comments · Fixed by #198 or #331
Closed

UI Structure: ConceptCardFragment #160

BenHenning opened this issue Sep 20, 2019 · 2 comments · Fixed by #198 or #331
Assignees
@jamesxu0
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@BenHenning
Copy link
Member

This is tracking implementing the initial UI structure for the concept card fragment that's being fully implemented by #24.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 20, 2019
@BenHenning BenHenning changed the title UI Structure: ConceptCardFragment [] UI Structure: ConceptCardFragment [Blocked: #118] Sep 20, 2019
@BenHenning
Copy link
Member Author

This is blocked on #118.

@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
3 tasks
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Merged
6 tasks
jamesxu0 added a commit that referenced this issue Sep 23, 2019
@jamesxu0
Fixes part 1 of #160: initial structure for Concept Card (#148)
e74c827 
initial structure for Concept Card
@BenHenning BenHenning changed the title UI Structure: ConceptCardFragment [Blocked: #118] UI Structure: ConceptCardFragment Sep 30, 2019
@jamesxu0 jamesxu0 mentioned this issue Sep 30, 2019
Merged
6 tasks
jamesxu0 added a commit that referenced this issue Oct 11, 2019
@jamesxu0
Fixes #160: Integrating topic controller into Concept Card (#198)
f1ec4bf 
* Introduce a generic data-binding-enabled RecyclerView adapter. No tests
have yet been added.

* First attempt at introducing tests for BindableAdapter. They aren't fully
working yet.

* Updated view model

* Added bindable recycler view and test activity

* Finished test cases

* Using bundle to get skillId

* Minor fixes and added tests

* Fixed test cases with ActivityTestRule

* Undo unnecessary removal of optional modifier for onAttach callback.

* Fix and finish tests for BindableAdapter.

* Address review comment.

* removed unnecessary import

* Tests now using activity scenario

* Fixed package name
@BenHenning BenHenning mentioned this issue Oct 23, 2019
Merged
6 tasks
@jamesxu0 jamesxu0 reopened this Nov 11, 2019
@jamesxu0 jamesxu0 mentioned this issue Nov 11, 2019
Merged
8 tasks
@BenHenning
Copy link
Member Author

@jamesxu0 what work remains here?

jamesxu0 added a commit that referenced this issue Nov 19, 2019
@jamesxu0
Fixes #160: Add HTML parsing to ConceptCardFragment (#331)
b60a8e1 
* Added html parsing

* Added title to toolbar

* refactored viewModel to use fragment

* Moved sets to ViewModel

* updated name

* Consolidated recyclerview and wrote text cases that check for rich text

* Moved test activity to test folder

* removed long file

* Removed recyclerview and worked examples

* made host activity dismiss fragment

* Added comment for dismiss

* Fixed alignment

* Fixed formatting

* changed to getOrDefault

* changed test names
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesxu0 jamesxu0

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
2 participants
@BenHenning @jamesxu0