Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Tick Icon" in the QuestionPlayer disappears if the submitted answer is too long #1538

Closed
MohamedMedhat1998 opened this issue Jul 29, 2020 · 1 comment · Fixed by #1923
Closed

"Tick Icon" in the QuestionPlayer disappears if the submitted answer is too long #1538

MohamedMedhat1998 opened this issue Jul 29, 2020 · 1 comment · Fixed by #1923
Assignees
@prayutsu
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@MohamedMedhat1998
Copy link
Contributor

Describe the bug
In the QuestionPlayer, the "Tick Icon" appears when the submitted answer is correct. But if the submitted answer TextView is long enough to fill its parent, it pushes the "Tick Icon" off the borders of its parent. So, it disappears.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Topic/Fractions/Practice"
  2. Select the first 3 skills then click start
  3. Play the questions till you reach "Amir says the shaded black ..."
  4. Select the correct answer "No, Amir needs to divide ..."
  5. Notice that the "Tick Icon" doesn't appear.

Expected behavior
The "Tick Icon" should appear and the TextView width shouldn't push it off the layout.

Screenshots
screenshot-2020-07-29_08 12 36 241

Device

  • Google Pixel C
  • SDK version 25
@rt4914 rt4914 added the SLoP-75 label Sep 24, 2020
@prayutsu
Copy link
Contributor

@MohamedMedhat1998 I would like to take up this issue

@prayutsu prayutsu mentioned this issue Oct 1, 2020
Merged
8 tasks
BenHenning pushed a commit that referenced this issue Nov 17, 2020
@prayutsu
Fix #1538: "Tick Icon" in the QuestionPlayer disappears if the submit…
6e550ed 
…ted answer is too long (#1923)

* test answer tick

* test on recyclerview

* revert recyclerview changes

* add maxWidth

* fixed major part of bug

* fix bug for portrait layout

* add binding adapter

* try fixing new bug

* try fixing errors

* fix extra space when answer is incorrect

* fix reviewed changes

* fix nit change

* annotated binding function with proper annotations

* fix error in BUILD.bazel

* fix all checks

* fix bug for all layouts

* fixed suggested changes

* update guideline name

* fix failing checks

* add tests case

* add test

* fix tickicontest

* tried adding a complete test

* Try removing Linearlayout

* corrected errors in testcase

* corrected errors in testcase

* tried adding position assertion

* resolved merge conflicts successfully

* removed LinearLayout from portrait phone layout

* fix test case

* try adding position assertion

* fixed test case for phone portrait-layout

* removed LinearLayout from all the layouts

* fix suggested changes

* fix reviewed changes

* fixed nit changes

* fixed errors in landscape and tablet layouts

* fixed nit

* add new case to test

* update test case

* move test case to QuestionPlayerActivityTest.kt

* fix reviewed changes

* fix suggested changes

* fix nits

* fix nits

* remove extra line

* Added TODOs and RunOn(ESPRESSO) annotation

* fix lint errors

* fix nits

* fix nits
@rt4914 rt4914 added SLoP-150 and removed SLoP-75 labels Nov 17, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prayutsu prayutsu

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
4 participants
@MohamedMedhat1998 @rt4914 @BenHenning @prayutsu