Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & drop drag state resets after an incorrect answer #1468

Closed
BenHenning opened this issue Jul 13, 2020 · 10 comments · Fixed by #5541
Closed

Drag & drop drag state resets after an incorrect answer #1468

BenHenning opened this issue Jul 13, 2020 · 10 comments · Fixed by #5541
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Jul 13, 2020

Describe the bug
When using the drag & drop interaction, an incorrect answer results in the same drag state being shown.

To Reproduce
Steps to reproduce the behavior:

  1. Start the Prototype Exploration on a dev build of the app
  2. Play through it until the first drag & drop state
  3. Drag the items to produce an incorrect answer
  4. Submit the answer
  5. Observe that the drag & drop order resets back to the original state

Expected behavior
The drag & drop order should stay the same after the incorrect answer.

Screenshot
oppia_drag_drop_not_retaining_state

Device

  • Device: Pixel XL
  • SDK: 29

Additional Information

Comment #1468 (comment) was addressed in #5478.

@BenHenning BenHenning added Type: Bug Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jul 13, 2020
@BenHenning BenHenning added this to the GSoC 2020 4.3: Milestone 2 milestone Jul 13, 2020
@BenHenning
Copy link
Member Author

As discussed, since this needs to apply to all interactions we're not blocking M2 on this work item.

@BenHenning BenHenning modified the milestones: GSoC 2020 4.3: Milestone 2, Beta Jul 21, 2020
@BenHenning
Copy link
Member Author

This probably also happens during configuration changes.

@anandwana001
Copy link
Contributor

@aggarwalpulkit596 still working on this?

@aggarwalpulkit596
Copy link
Contributor

This was something a bit out of scope with the current implementation of interactions and viewmodels. It won't be possible unless we move to hilt or something better.

@BenHenning
Copy link
Member Author

I think we're solving this for the other interactions using a singleton that retrieves state from the assembler. See #2514 for specifics. @FareesHussain do you think that approach could work here?

@BenHenning
Copy link
Member Author

Deassigning you @aggarwalpulkit596 since it seems that you're not actively working on this.

@FareesHussain
Copy link
Contributor

I think we're solving this for the other interactions using a singleton that retrieves state from the assembler. See #2514 for specifics. @FareesHussain do you think that approach could work here?

I'm not sure here, so far my implementation didn't give any desired result. I've completely forgotten my singleton pr. I will try once again using the setState similar to #2557

@aggarwalpulkit596
Copy link
Contributor

@FareesHussain let me know if i can be of any help.

@BenHenning BenHenning modified the milestones: Beta, Beta MR1, Beta MR2 Jun 11, 2022
@Akshatkamboj14 Akshatkamboj14 self-assigned this Mar 7, 2023
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. work label added labels May 3, 2023
@Akshatkamboj14 Akshatkamboj14 self-assigned this Oct 2, 2023
@adhiamboperes adhiamboperes removed the Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. label Jan 24, 2024
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@adhiamboperes
Copy link
Collaborator

@TanishMoral11, PTAL.

@Rd4dev
Copy link
Collaborator

Rd4dev commented Sep 18, 2024

Just adding for reference (not working and not approved):

I tried to get the previous pendingState.wrongAnswerList to pass for computing the strings - Code sample. However, I haven't yet figured a way to update the adapter with the same:

  1. It always instantly fell back to the empty list, providing the default list since LiveData was gathered asynchronously.
  2. To obtain and update the adapter into the content view model.

I’m adding this for future reference as I’m currently considering moving on to another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

10 participants