Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI: Topic review tab fragment [Blocked: #15, #142] #143

Closed
BenHenning opened this issue Sep 19, 2019 · 3 comments · Fixed by #930
Closed

Final UI: Topic review tab fragment [Blocked: #15, #142] #143

BenHenning opened this issue Sep 19, 2019 · 3 comments · Fixed by #930
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.3 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 19, 2019 •
edited by rt4914
Loading

This is tracking implementing the high fidelity UI for the topic review tab.

https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/1adacef0-f245-4115-a0e0-d1c2e7d5a0bb/TP-Revision-/

https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/dad2a9ff-ce33-4f00-894a-ec07dbb12797/TP-Revision-
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 19, 2019
@BenHenning
Copy link
Member Author

This is blocked on #142 for structure and #15 for full domain functionality.

@rt4914 rt4914 assigned rt4914 and nikitamarysolomanpvt and unassigned rt4914 Oct 29, 2019
This was referenced Nov 5, 2019
Merged
Closed
rt4914 added a commit that referenced this issue Nov 15, 2019
@rt4914
Fix part of #143: Review card changes (#354)
4e3be63 
* Fix review card

* Nit changes
@rt4914
Copy link
Contributor

rt4914 commented Jan 16, 2020

Opening this again as the design needs to be updated as per version v7.

@rt4914 rt4914 reopened this Jan 16, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jan 16, 2020

Assigning this to @Luffy18346

@rt4914 rt4914 self-assigned this Jan 16, 2020
@rt4914 rt4914 mentioned this issue Apr 1, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Apr 7, 2020
@rt4914
Fix #143: Highfi TopicRevision Updated (#930)
d18c59d 
* Updated UI

* Updated implementation

* Updated UI

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.3 Release Blockers (Prototype MR3) ...
Development

Successfully merging a pull request may close this issue.

Fix #143: Highfi TopicRevision Updated oppia/oppia-android
3 participants
@rt4914 @BenHenning @nikitamarysolomanpvt