Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit button needs to be correctly activated/deactived in player #1344

Closed
1 of 2 tasks
rt4914 opened this issue Jun 17, 2020 · 0 comments · Fixed by #1443
Closed
1 of 2 tasks

Submit button needs to be correctly activated/deactived in player #1344

rt4914 opened this issue Jun 17, 2020 · 0 comments · Fixed by #1443
Assignees
@rt4914 @nikitamarysolomanpvt
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jun 17, 2020 •
edited
Loading

Currently in Exploration Player and Question Player the Submit button is active by default but instead it should be correctly controlled as active/deactive.

Submit button should be active under following conditions only:

  1. Atleast some answer should be available for submission.
  2. There is should be no pending error from input interactions.

Other than this Submit button should be deactive in all cases.

Checklist:

  • Fix this in Exploration Player (@rt4914 )
  • Fix this in Question Player (@rt4914 )
@rt4914 rt4914 assigned BenHenning and rt4914 and unassigned BenHenning Jun 17, 2020
@rt4914 rt4914 mentioned this issue Jun 17, 2020
Merged
8 tasks
@rt4914 rt4914 added this to the Alpha milestone Jun 18, 2020
rt4914 added a commit that referenced this issue Jun 19, 2020
@rt4914
Fixes part of #1344: Submit button active/deactive (#1330)
5377c3d 
* submit button active/deactive [skip CI]

* ItemSelection button control

* Default button is inactive[skip CI]

* Submit button final changes

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Lowfi UI labels Jun 23, 2020
@rt4914 rt4914 mentioned this issue Jul 6, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Jul 6, 2020
@rt4914
Fix #1344: Submit button active/deactive in Question Player (#1443)
b9e1568 
* Submit button active/inactive

* Nit ktlint fix

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

@nikitamarysolomanpvt nikitamarysolomanpvt

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1344: Submit button active/deactive in Question Player oppia/oppia-android
3 participants
@rt4914 @BenHenning @nikitamarysolomanpvt