Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce interface for ExplorationDataController #121

Closed
BenHenning opened this issue Sep 17, 2019 · 5 comments · Fixed by #193
Closed

Introduce interface for ExplorationDataController #121

BenHenning opened this issue Sep 17, 2019 · 5 comments · Fixed by #193
Assignees
@vinitamurthi
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.1 Release Block...

Comments

@BenHenning
Copy link
Member

This is tracking introducing a stubbed interface for #113 without the real implementation being complete.
@BenHenning BenHenning mentioned this issue Sep 17, 2019
Closed
@BenHenning BenHenning added this to the Prototype -- Infra milestone Sep 17, 2019
@BenHenning BenHenning added Where: Infrastructure Priority: Essential This work item must be completed for its milestone. labels Sep 17, 2019
This was referenced Sep 20, 2019
Closed
Closed
Open
@BenHenning
Copy link
Member Author

@vinitamurthi you mentioned that you were interested in working on this.

@BenHenning BenHenning mentioned this issue Sep 23, 2019
Closed
1 task
@BenHenning
Copy link
Member Author

FYI @vinitamurthi we are planning to get this checked in by EOW. Please let me know if that's not feasible.

@vinitamurthi
Copy link
Contributor

For now, a getExplorationById() should be sufficient

@BenHenning
Copy link
Member Author

For references look at #177 and #174 for how to stub & test similar controllers.

@BenHenning
Copy link
Member Author

For the stub, maybe we could pull in some of the demo explorations from the file system: https://github.com/oppia/oppia/tree/develop/data/explorations. We could convert a few of these over to JSON and include them in the app.

@rt4914 rt4914 mentioned this issue Sep 27, 2019
Closed
@vinitamurthi vinitamurthi mentioned this issue Sep 27, 2019
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Sep 29, 2019
@vinitamurthi @BenHenning
Fix #121: Create an exploration data controller (#193)
4c92398 
* Initial check in for the ExplorationDataController

* Load json asset into a JSON object

* Use data provider and add state creation

* fix warnings

* Added interactions

* Added customization args

* Initial structure for the test file and remove interactive map from the sample explorations

* Add initial tests

* add states to the exploration

* Added exploration tests

* Added comments

* Made null check more readable

* Review changes

* Lint fix

* Used android studio reformatting

* Lint fixes, remove print statement
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinitamurthi vinitamurthi

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
0.1 Release Blockers (Prototype MR1)
Development

Successfully merging a pull request may close this issue.

Fix #121: Create an exploration data controller oppia/oppia-android
2 participants
@vinitamurthi @BenHenning