Fix # 3581 Merge topic_lessons_story_summary.xml (#4234)

* Optimised the layout files * Added space * Remmoved Extra dimens
oppia · May 5, 2022 · bde9242 · bde9242
1 parent 9d9403c
commit bde9242
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 358 deletions.
diff --git a/app/src/main/res/layout-land/topic_lessons_story_summary.xml b/app/src/main/res/layout-land/topic_lessons_story_summary.xml
diff --git a/app/src/main/res/layout-sw600dp-land/topic_lessons_story_summary.xml b/app/src/main/res/layout-sw600dp-land/topic_lessons_story_summary.xml
@@ -39,8 +39,8 @@
         <LinearLayout
           android:layout_width="match_parent"
           android:layout_height="wrap_content"
-          android:layout_marginStart="16dp"
-          android:layout_marginEnd="16dp"
+          android:layout_marginStart="@dimen/topic_lessons_summary_card_view_margin_start"
+          android:layout_marginEnd="@dimen/topic_lessons_summary_card_view_margin_end"
           android:layout_marginBottom="24dp"
           android:orientation="horizontal">
 
@@ -96,7 +96,7 @@
               android:id="@+id/story_name_chapter_count_container"
               android:layout_width="0dp"
               android:layout_height="wrap_content"
-              android:layout_marginStart="20dp"
+              android:layout_marginStart="@dimen/topic_lessons_summary_story_name_chapter_count_container_margin_start"
               android:layout_weight="1"
               android:contentDescription="@{viewModel.computeStoryNameChapterCountContainerContentDescription()}"
               android:gravity="center_vertical"

diff --git a/app/src/main/res/layout-sw600dp-port/topic_lessons_story_summary.xml b/app/src/main/res/layout-sw600dp-port/topic_lessons_story_summary.xml
diff --git a/app/src/main/res/values-land/dimens.xml b/app/src/main/res/values-land/dimens.xml
@@ -488,6 +488,13 @@
   <dimen name="option_audio_language_padding_start">36dp</dimen>
   <dimen name="option_audio_language_padding_end">36dp</dimen>
 
+  <!-- TopicLessonsSummary -->
+  <dimen name="topic_lessons_summary_card_view_margin_start">96dp</dimen>
+  <dimen name="topic_lessons_summary_card_view_margin_end">96dp</dimen>
+  <dimen name="topic_lessons_summary_linear_layout_margin_start">16dp</dimen>
+  <dimen name="topic_lessons_summary_linear_layout_margin_end">16dp</dimen>
+  <dimen name="topic_lessons_summary_story_name_chapter_count_container_margin_start">20dp</dimen>
+
   <!-- OptionsStoryTextSize -->
   <dimen name="option_story_text_size_padding_start">36dp</dimen>
   <dimen name="option_story_text_size_padding_end">36dp</dimen>