-
Notifications
You must be signed in to change notification settings - Fork 533
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix All warnings in "Usability:Typography", "Usability:Icons", and "U…
…sability" categories (#5196) <!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> Fixes #5194 [part of #5182] Fixes all warning in "Usability" category caused by - **Borderless Buttons :** Fixed by introducing `style="?android:attr/buttonBarButtonStyle"` to the borderless buttons - **OK text capitalization :** Fixed by suppressing the lint warnings for `ButtonCase` and `Typos` - **Ellipsis/Hyphen unicode replacement :** Fixed by introducing unicode representations (under review) - **Image in density drawable folder :** Fixed by creating seperate density images (under review) - **Text size too small :** Fixed by upscaling text size to `12sp` - **To incorporate Autofill :** Fixed by incorporating `autofillHints` to the EditText ## ScreenShot ![Before After Usability Lint Issues](https://github.com/oppia/oppia-android/assets/122200035/5a7037f5-ca22-482a-a0f3-8af2bfc8b75c) ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). --------- Co-authored-by: Adhiambo Peres <[email protected]> Co-authored-by: Ben Henning <[email protected]>
- Loading branch information
1 parent
6723268
commit 9ad24ef
Showing
19 changed files
with
34 additions
and
14 deletions.
There are no files selected for viewing
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<resources> | ||
<resources xmlns:tools="http://schemas.android.com/tools"> | ||
<string name="nav_header_desc">Navigation header</string> | ||
<string name="menu_options">Options</string> | ||
<string name="menu_my_downloads">My Downloads</string> | ||
|
@@ -16,13 +16,13 @@ | |
<string name="audio_play_description">Play audio</string> | ||
<string name="audio_pause_description">Pause audio</string> | ||
<string name="audio_unavailable_in_selected_language">%s audio is unavailable.</string> | ||
<string name="audio_language_select_dialog_okay_button">Ok</string> | ||
<string name="audio_language_select_dialog_okay_button" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="audio_language_select_dialog_cancel_button">Cancel</string> | ||
<string name="audio_language_select_dialog_title">Audio Language</string> | ||
<string name="audio_dialog_offline_title">Currently Offline</string> | ||
<string name="audio_dialog_offline_message">Make sure Wi-Fi or cellular data is turned on, then try again.</string> | ||
<string name="audio_dialog_offline_positive">Ok</string> | ||
<string name="cellular_data_alert_dialog_okay_button">Ok</string> | ||
<string name="audio_dialog_offline_positive" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="cellular_data_alert_dialog_okay_button" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="cellular_data_alert_dialog_cancel_button">Cancel</string> | ||
<string name="cellular_data_alert_dialog_title">Currently on Cellular Data</string> | ||
<string name="cellular_data_alert_dialog_description">Streaming audio may use a lot of cellular data.</string> | ||
|
@@ -377,7 +377,7 @@ | |
<string name="administrator_controls_account_actions_label">Account Actions</string> | ||
<string name="administrator_controls_log_out">Log Out</string> | ||
<string name="log_out_dialog_cancel_button">Cancel</string> | ||
<string name="log_out_dialog_okay_button">Ok</string> | ||
<string name="log_out_dialog_okay_button" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="log_out_dialog_message">Are you sure you want to log out of your profile?</string> | ||
<!-- AppVersionFragment --> | ||
<string name="app_version_name">App Version %s</string> | ||
|
@@ -490,11 +490,11 @@ | |
<string name="beta_notice_dialog_title">Beta Notice</string> | ||
<string name="beta_notice_dialog_message">Hello! Your app is now being updated to the Beta version. If you experience problems while using the app, or have questions, please contact us at [email protected].</string> | ||
<string name="beta_notice_dialog_do_not_show_again_text">Don\'t show this message again</string> | ||
<string name="beta_notice_dialog_close_button_text">OK</string> | ||
<string name="beta_notice_dialog_close_button_text" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="general_availability_notice_dialog_title">General Availability Notice</string> | ||
<string name="general_availability_notice_dialog_message">Hello! Your app is now being updated to the General Availability version. If you experience problems while using the app, or have questions, please contact us at [email protected].</string> | ||
<string name="general_availability_notice_dialog_do_not_show_again_text">Don\'t show this message again</string> | ||
<string name="general_availability_notice_dialog_close_button_text">OK</string> | ||
<string name="general_availability_notice_dialog_close_button_text" tools:ignore="ButtonCase,Typos">Ok</string> | ||
<string name="ratio_content_description_separator" description="The separator that would be used to build the text that would be read out for ratio interaction.For e.g if the input is 1:2:3 the read out text would be 1 to 2 to 3">\u0020to\u0020</string> | ||
<string name="ratio_default_hint_text" description="The default hint text for the ratio interaction if the placeholder text is not available.">Enter a ratio in the form x:y.</string> | ||
<string name="text_input_default_hint_text">Tap here to enter text.</string> | ||
|