-
Notifications
You must be signed in to change notification settings - Fork 531
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…and MultiTypeBuilder (#4412) * Replace builder() with Factory in SingleTypeBuilder and MultiTypeBuilder. * Fix failing tests after refactor, Create Fragment for DragDropTestActivity.kt. * Inject the BindableAdapter.kt factory into the fragment and listview instances. * Inject the BindableAdapter.kt factory into the fragment and listview instances. * Inject the BindableAdapter.kt factory into the fragment and listview instances. * Inject the BindableAdapter.kt factory into the fragment and listview instances. * Add 'androidx.work:work-testing:2.4.0' in androidTestImplementation to fix tests. * Fix lint formatting issue in updated files. * Fix some of the failing tests after fixing #2658. * Fix some of the failing tests after fixing #2658. * Fix more failing tests for #2658. * Refactor StatePlayerRecyclerViewAssembler.kt to inject MultiTypeAdapterFactory * Fix failing tests due to missed refactor of QuestionPlayerFragmentPresenter.kt to inject MultiTypeAdapter Factory. * More updates as part of refactoring for issue #2658. * Refactor PromotedStoryListView.kt BindableAdapterTest.kt classes to provide Adapter through injection for isuue #2658. * Fix issues as advised by code review. * Fix issue causing some of failing tests. * Fix issue causing some of failing tests. * Revert unused resources, to fix Static check test failure. * Add KDocs to implemented public functions, to fix KDocs Static check test failure. * Add exemption for test to DragDropTestFragmentPresenter and DragDropTestFragment since they are actual test classes. * Fix nits and updates as advised during code review. * Fix nits and updates as advised during code review. * Fix nits and updates as advised during code review. * Updates issues as advised on code review, fix some of the failing tests. * Fix failing tests. * Fix more failing tests by reverting DragDropSortInteractionView.kt and SelectionInteractionView.kt to initial state. * Update multiple field namings for consistency as advised by code reviewer. * Fix failing tests and revert from previous fix, which could not be used in alpha. * Fix out-of-order binding for selection, drop/drop. * Post-merge fixes. Mainly, this fixing previous code as well as image region selection (which whose breakage could only be detected via manually playing the image region selection and by running the interaction's corresponding test suite on Espresso, both of which caught different sets of issues). The PR includes some cleanup work as well. * Fix lint issues after resolving merge conflicts on CI and add lessons_chapter_view.xml which is not available on my branch even after several sync's causing build errors. * Revert deleted deltas. * Remove lessons_chapter_view.xml since it is no longer required. Co-authored-by: Ben Henning <[email protected]>
- Loading branch information
1 parent
f096b1d
commit 8594c9d
Showing
56 changed files
with
929 additions
and
899 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.