Fix #3822: Remove maxLines contsraint's to enable long text to linebr…

…eak (#4547) * Reduce MarginStart and MarginEnd. * Update maxLines to automatically to show extra text on new line. * Update maxLines for other portrait layouts. * Make changes as requested on review. * Make more changes as advised by reviewer.
oppia · Sep 16, 2022 · 1eebfb5 · 1eebfb5
1 parent f99fa1d
commit 1eebfb5
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 4 deletions.
diff --git a/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml b/app/src/main/res/layout-sw600dp-port/onboarding_slide.xml
@@ -41,7 +41,6 @@
         android:layout_marginTop="48dp"
         android:layout_marginEnd="160dp"
         android:gravity="center_horizontal"
-        android:maxLines="1"
         android:text="@{viewModel.title}"
         android:textSize="32sp"
         app:layout_constraintEnd_toEndOf="parent"

diff --git a/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml b/app/src/main/res/layout-sw600dp-port/onboarding_slide_final.xml
@@ -43,7 +43,6 @@
         android:layout_marginEnd="160dp"
         android:fontFamily="sans-serif-medium"
         android:gravity="center_horizontal"
-        android:maxLines="1"
         android:text="@string/onboarding_slide_3_title"
         android:textSize="32sp"
         app:layout_constraintEnd_toEndOf="parent"

diff --git a/app/src/main/res/layout/onboarding_slide.xml b/app/src/main/res/layout/onboarding_slide.xml
@@ -43,7 +43,6 @@
         android:layout_marginBottom="16dp"
         android:fontFamily="sans-serif-medium"
         android:gravity="center_horizontal"
-        android:maxLines="1"
         android:text="@{viewModel.title}"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"

diff --git a/app/src/main/res/layout/onboarding_slide_final.xml b/app/src/main/res/layout/onboarding_slide_final.xml
@@ -45,7 +45,6 @@
         android:layout_marginBottom="16dp"
         android:fontFamily="sans-serif-medium"
         android:gravity="center_horizontal"
-        android:maxLines="1"
         android:text="@string/onboarding_slide_3_title"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"