Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix #3188 This PR enhances the `ImageTagHandler` to support captions in the `oppia-noninteractive-image` custom tag. - The caption-with-value attribute is now parsed. - The caption text is included as readable text following the image. ## Before ![IMG-20241214-WA0001](https://github.com/user-attachments/assets/746dd49c-f54f-47a8-aebb-dec821e057be) ![IMG-20241214-WA0003](https://github.com/user-attachments/assets/20a73d23-6987-4cab-811b-32313eff3076) ## After ![IMG-20241214-WA0005](https://github.com/user-attachments/assets/044d93ec-75c8-44a7-ad11-6bea16a39651) ![WhatsApp Image 2024-12-17 at 19 25 11_ae9c0cb6](https://github.com/user-attachments/assets/f45c01c3-23d9-4781-b26d-c6076e96828e) ![IMG-20241214-WA0006](https://github.com/user-attachments/assets/6f0d3204-5119-4d45-bfb6-3831529b1ee7) ![WhatsApp Image 2024-12-17 at 19 25 11_1c80032d](https://github.com/user-attachments/assets/a53b8143-6a24-4363-9c84-3e5702911fb2) ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
- Loading branch information