Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rails3 broken links in deep neested pages #76

Merged

Conversation

tessi
Copy link
Collaborator

@tessi tessi commented Apr 22, 2013

When the user navigates into nested pages (e.g. /projects/foo/issues/report) the menu links were broken. See openproject.org issue #426

This is now tested in a cuke, fixed, and ready for review.

@apfelfabrik
Copy link
Contributor

Works on my machine!
tumblr_inline_ml4701KEWE1qz4rgp

apfelfabrik added a commit that referenced this pull request Apr 22, 2013
…eested_pages

Feature/rails3 broken links in deep neested pages
@apfelfabrik apfelfabrik merged commit d450819 into feature/rails3 Apr 22, 2013
@tessi
Copy link
Collaborator Author

tessi commented Apr 22, 2013

There are possibly many more places where we should use the :controller => '/controller_name' syntax.

@tessi
Copy link
Collaborator Author

tessi commented Apr 22, 2013

How can I repoen this pull request?

@apfelfabrik
Copy link
Contributor

You can't. We need a new one.

@tessi
Copy link
Collaborator Author

tessi commented Apr 22, 2013

You're right, you can't. Find the new pull request here: #77

ulferts pushed a commit that referenced this pull request Nov 15, 2018
ulferts added a commit that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants