Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation/59467 add global settings to enforce input of start and end times #17249

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Implementation/59467 add global settings to enforce input of start and end times #17249

wants to merge 6 commits into from

Conversation

klaustopher
Copy link
Contributor

@klaustopher klaustopher commented Nov 21, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/59467

What are you trying to accomplish?

Adding another setting that enforces the start and end times are entered. I also added validations on the TimeEntry model so that we do not allow:

  • values outside of 00:00 and 23:59
  • start > end
  • non-integer values

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@klaustopher klaustopher changed the title Implementation/59467 add global and project settings to enforce input of start and end times Implementation/59467 add global settings to enforce input of start and end times Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@klaustopher