Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Add optional field to BundleDeployment API to enable/disable CRD upgrade safety preflight checks #902

Merged

Conversation

rashmigottipati
Copy link
Member

Description

Adds a new, optional field to the BundleDeployment API spec for enabling/disabling the CRD Upgrade Safety preflight checks. The default state should be enabled.

No logic included in this PR as the CRD Upgrade Safety preflight check as there isn't anything yet to enable/disable. So logic to enable/disable will be added in a follow-up

fixes operator-framework/operator-controller#745
original PR in operator-controller: operator-framework/operator-controller#845

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 14.41%. Comparing base (f62d497) to head (84010f8).

Files Patch % Lines
api/v1alpha2/zz_generated.deepcopy.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   14.55%   14.41%   -0.14%     
==========================================
  Files          41       41              
  Lines        2529     2553      +24     
==========================================
  Hits          368      368              
- Misses       2104     2128      +24     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven previously approved these changes May 21, 2024
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

I'll hold on merging this for a bit to give @joelanford a chance to review in case he has any additional comments

everettraven
everettraven previously approved these changes May 23, 2024
…ade safety preflight checks

Signed-off-by: Rashmi Gottipati <[email protected]>
@rashmigottipati rashmigottipati added this pull request to the merge queue May 29, 2024
Merged via the queue into operator-framework:main with commit f5b290a May 29, 2024
8 of 10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration to the ClusterExtension API for disabling CRD Upgrade Safety validations
3 participants