This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Import groups linting #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci-lint will now group imports in the following order: - standard library - 3rd party packages outside of our Github org - packages from our Github org - local imports from rukpak Signed-off-by: Tayler Geiger <[email protected]>
Signed-off-by: Tayler Geiger <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage 36.63% 36.63%
=======================================
Files 9 9
Lines 868 868
=======================================
Hits 318 318
Misses 506 506
Partials 44 44 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds linter grouping to match configuration in operator-controller.
I did add dot grouping to rukpak since there are several dot imports in the test files for ginkgo and gomega. However, the revive linter does complain about the dot imports.