Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

WIP [v1alpha2]: refactor controller #2003

WIP [v1alpha2]: refactor controller

WIP [v1alpha2]: refactor controller #2003

Triggered via pull request September 18, 2023 19:47
Status Failure
Total duration 2m 59s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

sanity.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 9 warnings
verify
Process completed with exit code 2.
lint: internal/controllers/v1alpha2/source/git.go#L92
Error return value is not checked (errcheck)
lint: internal/controllers/v1alpha2/source/git.go#L23
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
lint: internal/controllers/v1alpha2/source/image.go#L18
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
lint: internal/controllers/v1alpha2/source/unpacker.go#L10
File is not `goimports`-ed with -local github.com/operator-framework/rukpak (goimports)
lint: internal/controllers/v1alpha2/source/git.go#L156
G404: Use of weak random number generator (math/rand instead of crypto/rand) (gosec)
lint: internal/controllers/v1alpha2/source/image.go#L283
G305: File traversal when extracting zip/tar archive (gosec)
lint: internal/controllers/v1alpha2/source/image.go#L288
G305: File traversal when extracting zip/tar archive (gosec)
lint: internal/controllers/v1alpha2/source/image.go#L293
G110: Potential DoS vulnerability via decompression bomb (gosec)
lint: internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L160
`unkown` is a misspelling of `unknown` (misspell)
lint: internal/controllers/v1alpha2/controllers/bundledeployment/bundledeployment.go#L163
`availabe` is a misspelling of `available` (misspell)
lint: internal/provisioner/registry/registry.go#L15
unused-parameter: parameter 'fsys' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/util/fs.go#L96
unused-parameter: parameter 'fs' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/source/image.go#L242
unused-parameter: parameter 'storagePath' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/source/git.go#L41
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/validator/validator.go#L42
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/validator/validator.go#L52
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/validator/validator.go#L58
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/controllers/v1alpha2/deployer/deploy.go#L81
exported: type name will be used as deployer.DeployerOption by other packages, and that stutters; consider calling this Option (revive)
lint: internal/controllers/v1alpha2/deployer/deploy.go#L222
receiver-naming: receiver name bd should be consistent with previous receiver name hd for helmDeployer (revive)