Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating go to 1.22 and k8s to 1.30 #6847

Closed
wants to merge 1 commit into from

Conversation

acornett21
Copy link
Contributor

Description of the change:
Updating go, k8s, kubebuilder and supporting dependencies to the proper version to support go 1.22 and k8s 1.30.

Motivation for the change:
To keep this project aligned with kubbuilder and support k8s 1.30.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@acornett21
Copy link
Contributor Author

@Neo2308 I'm hoping this is most of the things, but still WIP. Also need to work on a changelog doc for this. If kubebuilder has a changelog, I'll probably just model it after that, thoughts?

@Neo2308
Copy link
Contributor

Neo2308 commented Oct 22, 2024

Yeah, sounds good. Some changes will be needed to fix the builds.

@@ -176,12 +176,12 @@ cluster-create::

.PHONY: dev-install
dev-install::
$(SCRIPTS_DIR)/fetch kind 0.17.0
$(SCRIPTS_DIR)/fetch kind 0.23.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to have a variable that holds this value? Update would require changing only it instead of the places that need it

@acornett21
Copy link
Contributor Author

@acornett21 acornett21 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
3 participants