removed path check as kubectl is handling path in it #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
changed the title
|
Took a look and it looks good to me. Since I am still new, I will leave the approvals to others. |
Sure @everettraven - thank you for reviewing it. |
Signed-off-by: laxmikantbpandhare <[email protected]>
Signed-off-by: laxmikantbpandhare <[email protected]>
Signed-off-by: laxmikantbpandhare <[email protected]>
|
/lgtm can't get the CI to pass though, it keeps failing on some linkchecking garbage |
thank you @jberkhahn for trying multiple times. Yes, it was some link-checking error. My PR do not have any change in any of the docs. |
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
May 18, 2022
…ork#5648) * removed this check as kubectl is handling path in it * added changelog * removed test file Signed-off-by: laxmikantbpandhare <[email protected]> Signed-off-by: Venkat Ramaraju <[email protected]>
VenkatRamaraju
pushed a commit
to VenkatRamaraju/operator-sdk
that referenced
this pull request
May 18, 2022
…r-framework#5648)" This reverts commit 62ac861.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Previously we added this error to show the user that the Path component is part of proxy server. Now, kubectl made this fix that handles this case and there is no need to throw this error anymore.
Motivation for the change:
The user should be able to run the operator with the proxy path in it.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs