Upgrade deps with go 1.17 #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
bump-sdk
branch
4 times, most recently
from
bf4d979 to
ff1567c
Compare
camilamacedo86
force-pushed
the
bump-sdk
branch
from
69f776c to
e3f289e
Compare
camilamacedo86
commented
Jan 19, 2022
camilamacedo86
commented
Jan 19, 2022
| ) | ||
|
|
||
| exclude github.com/spf13/viper v1.3.2 // Required to fix CVE-2018-1098 |
There was a problem hiding this comment.
it is no longer added
camilamacedo86
commented
Jan 19, 2022
| // Using containerd 1.4.0+ resolves an issue with invalid error logging | ||
| // from an init function in containerd. This replace can be removed when | ||
| // one of our direct dependencies begins using containerd v1.4.0+ | ||
| github.com/containerd/containerd => github.com/containerd/containerd v1.4.3 |
There was a problem hiding this comment.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| - fabianvf | ||
| - jberkhahn |
There was a problem hiding this comment.
Should this be done in a separate PR?
There was a problem hiding this comment.
| @@ -12,7 +12,6 @@ approvers: | |||
| reviewers: | |||
| - asmacdo | |||
| - camilamacedo86 | |||
| - estroz | |||
There was a problem hiding this comment.
This too, in a separate PR maybe?
There was a problem hiding this comment.
I am not sure how this file is working but it is only updated because was falling in the sanity. I updated with the sanity to make it pass.
There was a problem hiding this comment.
It shows that needs to be updated because of : https://github.com/operator-framework/operator-sdk/pull/5483/files.
Co-authored-by: Varsha <[email protected]>
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
asmacdo
removed
the
do-not-merge/hold
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Upgrade deps with go 1.17:
Motivation for the change:
Closes: #5503
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs