Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jberkhahn for operator-sdk approver #5483

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

jberkhahn
Copy link
Contributor

Per the discussion at the meeting today, here's my application for approver. I'm apparently already a maintainer on the CNCF side of things so I think(?) this is the only thing to do, as the lists in operator-framework/community don't seem like they need to change.

Also I sorted the lists because I couldn't stand them not being in alphabetical order, sorry.

@asmacdo

@jmrodri jmrodri changed the title Jberkhahn for OperatorSDK Approver jberkhahn for operator-sdk approver Jan 12, 2022
@jmrodri
Copy link
Member

jmrodri commented Jan 12, 2022

@jberkhahn looks like this PR failed DCO so please sign the commit.

Signed-off-by: Jonathan Berkhahn <[email protected]>
@jberkhahn jberkhahn force-pushed the jberkhahn_maintainer branch from ade0e77 to 035a8f4 Compare January 13, 2022 22:18
@jberkhahn
Copy link
Contributor Author

lol woops, fixed

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
@fabianvf
Copy link
Member

/lgtm

@asmacdo
Copy link
Member

asmacdo commented Jan 17, 2022

/lgtm

@asmacdo asmacdo merged commit 2a58202 into operator-framework:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants