Go 1.13

[chenrui333]

Description of the change:

Upgrade the repo to use go v1.13.

Previous efforts in here, #1949

Motivation for the change:

Homebrew build is using go v1.13, Homebrew/homebrew-core#45185

Also personal interest to bump the repo to use the latest golang offering.

[openshift-ci-robot]

Hi @chenrui333. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chenrui333]

/ok-to-test

[openshift-ci-robot]

@chenrui333: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joelanford]

I've actually been working on a branch for this myself, but this looks like a good start, so I'm happy to use this one.

There are a few more changes we need to make in this PR:

1. Refactor code that references GO111MODULE and GOPROXY environment variables, since there are new defaults in go1.13. I think the list of changes is probably:
   • Remove the lines in Makefile that set GO111MODULE and GOPROXY
   • Update internal/util/projutil.GoModOn() code and comments to handle new GO111MODULE behavior
   • Update error text in places that GoModOn is called to reflect new GO111MODULE behavior
2. Update comments and documentation to reflect the new requirement to use go1.13+ and the new Go tooling behavior (e.g. https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#go-modules)
3. Find any other references to go 1.12 and change them to go 1.13 (e.g. in hack/ci/setup-build-dependencies.sh)

Another thing we're planning to do when we switch to go 1.13 is drop support for generating projects to use dep, but I think we can probably do that as a separate PR since it isn't directly related.

[joelanford]

/ok-to-test

[joelanford]

@chenrui333 You can use #1949 to find the changes I made that I mentioned above. That PR also has the dep removal included as well, but for the sake of smaller PRs, I'd suggest ignoring those changes.

[camilamacedo86]

@joelanford.

I was using the 1.13 for a mistake and I checked the error; #2055

Which would be solved by replacing the version as the following example.
// Workaround to solve gin-gonic/gin#1673
github.com/ugorji/go v1.1.1 => github.com/ugorji/go/codec v0.0.0-20190204201341-e444a5086c43

Just to share in order to help with.

[chenrui333]

circle back on this now. Thanks for the direction, @joelanford !

[chenrui333]

looks like the pipeline:root still tagged by openshift/release:golang-1.12
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/operator-framework_operator-sdk/2040/pull-ci-operator-framework-operator-sdk-master-unit/2429/build-log.txt

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/operator-framework_operator-sdk/2040/pull-ci-operator-framework-operator-sdk-master-sanity/2432/build-log.txt

[chenrui333]

Relates to openshift/release#5443

[openshift-ci-robot]

@chenrui333: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/unit	da39cd5	link	/test unit
ci/prow/sanity	da39cd5	link	/test sanity
ci/prow/e2e-aws-go	da39cd5	link	/test e2e-aws-go
ci/prow/e2e-aws-helm	da39cd5	link	/test e2e-aws-helm
ci/prow/images	da39cd5	link	/test images
ci/prow/e2e-aws-ansible	da39cd5	link	/test e2e-aws-ansible
ci/prow/e2e-aws-subcommand	da39cd5	link	/test e2e-aws-subcommand

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[joelanford]

@chenrui333 It turns out we need the --dep-manager removal from #1949 a little sooner than I thought (for #2083). Since #1949 has those changes and is passing CI, I'm going to close this in favor of that.

Sorry about the mixup, and thanks for the contribution and assistance! More PRs are definitely welcome!

[chenrui333]

no problem, glad it works!