Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /. as the directory root to copy from. #361

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Jun 13, 2020

Description of the change:

Use <container>:/. instead of <container>:/ to copy out of bundles.

Motivation for the change:

A bug in podman makes cp <container>:/ <existing dir> create an additional dir and then opm fails:

[2020-06-13T11:05:56.384Z] time="2020-06-13T11:05:56Z" level=error msg="permissive mode disabled" bundles="[docker.io/ibmcom/ibm-cp-integration-bundle@sha256:2c29f6f774c18c0ac5be178aa1e0a73833ba42bfe7583b9095bb4bcd9890060b]" error="error loading bundle from image: unable to read directory bundle_tmp682869925/metadata: open bundle_tmp682869925/metadata: no such file or directory"

Podman bug is here: containers/podman#6596

Although I consider it a bug in podman (behaviour differs from docker), the docker documentation actually says that by ending the SRC_PATH in . we get the contents of the directory, which is actually what we want:
https://docs.docker.com/engine/reference/commandline/cp/

As such, I think this change introduces more correct behaviour.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 13, 2020
@openshift-ci-robot
Copy link

Hi @Jamstah. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jamstah
Copy link
Contributor Author

Jamstah commented Jun 13, 2020

/assign @dinhxuanvu

@Jamstah
Copy link
Contributor Author

Jamstah commented Jun 29, 2020

Can I get ok to test on this one?

@dinhxuanvu
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2020
@Jamstah
Copy link
Contributor Author

Jamstah commented Jun 29, 2020

Thank you, what are the next steps?

@dinhxuanvu
Copy link
Member

@kevinrizza @ecordell PTAL

@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jamstah, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c948ee3 into operator-framework:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants