-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /. as the directory root to copy from. #361
Use /. as the directory root to copy from. #361
Conversation
Hi @Jamstah. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dinhxuanvu |
Can I get ok to test on this one? |
/ok-to-test |
Thank you, what are the next steps? |
@kevinrizza @ecordell PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jamstah, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
Description of the change:
Use
<container>:/.
instead of<container>:/
to copy out of bundles.Motivation for the change:
A bug in podman makes
cp <container>:/ <existing dir>
create an additional dir and then opm fails:Podman bug is here: containers/podman#6596
Although I consider it a bug in podman (behaviour differs from docker), the docker documentation actually says that by ending the
SRC_PATH
in.
we get the contents of the directory, which is actually what we want:https://docs.docker.com/engine/reference/commandline/cp/
As such, I think this change introduces more correct behaviour.
Reviewer Checklist
/docs