Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache: fixup pogreb db permissions #1317

Merged

Conversation

joelanford
Copy link
Member

Description of the change:
This commit updates the pogreb cache such that file and directory permissions are updated so that the pogreb DB is read/writable by the group.

Motivation for the change:
In certain runtime situations, the user that owns the files inside the image is not the effective user when the image runs, resulting in permission errors when creating a DB lock and when reading the DB files.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 50.02%. Comparing base (e7ca8e3) to head (9f7939f).

Files Patch % Lines
pkg/cache/pogrebv1.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   50.06%   50.02%   -0.05%     
==========================================
  Files         135      135              
  Lines       12995    13006      +11     
==========================================
  Hits         6506     6506              
- Misses       5405     5416      +11     
  Partials     1084     1084              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3a4d9e1 into operator-framework:master May 17, 2024
9 of 11 checks passed
@joelanford joelanford deleted the cache-pogreb-fix branch May 17, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants