-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export parsed composite specs #1139
export parsed composite specs #1139
Conversation
/hold for consolidating types |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
=========================================
Coverage ? 53.82%
=========================================
Files ? 108
Lines ? 10199
Branches ? 0
=========================================
Hits ? 5490
Misses ? 3741
Partials ? 968
☔ View full report in Codecov by Sentry. |
0327319
to
1ddd983
Compare
Signed-off-by: Jordan Keister <[email protected]>
1ddd983
to
545b4cb
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I do have a teeny nit (totally non-blocking) - I personally prefer to have methods co-located with the type they are associated with because it makes it easier for me to dig into the code due to less jumping between different files.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
I'm of two minds on this. But we already had a If we find that it causes issue later, I'm totally OK with a future PR to move them out of that file so we can have everything in one place. |
Description of the change:
export parsed yaml/json specs so that other tooling can leverage it
Motivation for the change:
tap-fitter tooling will be able to generate some pipeline-specific pieces from the composite template, but the current implementation parses and executes the specs in an uninterrupted flow
example:
Reviewer Checklist
/docs