Proposal for PackageManifest Icon Subresource #985
Conversation
openshift-ci-robot
added
approved
|
@alecmerdler: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| var _ rest.Connecter = &LogoStorage{} | ||
| var _ rest.StorageMetadata = &LogoStorage{} | ||
|
|
||
| // Implement the necessary methods below... |
There was a problem hiding this comment.
Maybe a quick note about how we'll avoid a grpc roundtrip on every logo request?
There was a problem hiding this comment.
Do you have any suggestions on this? It seems difficult because the current PackageManifestProvider interface doesn't include a method to retrieve all PackageManifests to store their icons ahead-of-time (need to know the namespaces).
alecmerdler
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Addressing the tech debt of including base64 image data in the body of the
PackageManifestobject by creating a new subresource which serves the file data. Needed to address poor load times for OperatorHub.Proposal for https://jira.coreos.com/browse/OLM-1211