(doc) add doc for scoped operator install #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
dmesser
requested changes
Jul 29, 2019
There was a problem hiding this comment.
Generally looks good. A couple of thoughts:
- change the perspective to that of the user and refrain from using internal implementation, e.g.
- OLM controllers run with cluster-admin privileges vs. OLM runs with cluster-admin privileges
- OLM uses a client bound to a serviceaccount vs. the Operator can request any permissions
- use consistent nomenclature, e.g.
serviceaccountvs.ServiceAccountandolmvs.OLM - use of colloquial language: "OLM does not spit out..."
@dmesser addressed your feedback, please take a look when you have time. |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-upgrade |
|
/retest |
dmesser
requested changes
Jul 30, 2019
| @@ -0,0 +1,198 @@ | |||
| ## Background | |||
| OLM runs with `cluster-admin` privileges. By default, operator author can specify any set of permission(s) in the `csv` and OLM will consequently grant it to the operator. In effect, an operator can achieve `cluster-scoped` privilege(s) which may not always be desired. | |||
There was a problem hiding this comment.
Suggested change
| OLM runs with `cluster-admin` privileges. By default, operator author can specify any set of permission(s) in the `csv` and OLM will consequently grant it to the operator. In effect, an operator can achieve `cluster-scoped` privilege(s) which may not always be desired. | |
| OLM runs with `cluster-admin` privileges. By default, operator author can specify any set of permission(s) in the `CSV` and OLM will consequently grant it to the operator. In effect, an operator can achieve `cluster-scoped` privilege(s) which may not always be desired. |
| ## Background | ||
| OLM runs with `cluster-admin` privileges. By default, operator author can specify any set of permission(s) in the `csv` and OLM will consequently grant it to the operator. In effect, an operator can achieve `cluster-scoped` privilege(s) which may not always be desired. | ||
|
|
||
| OLM introduced a new feature that applies principle of attenuation to the operator being installed. The administrator can specify a service account with a set of privilege(s) granted to it. OLM will ensure that when an operator is installed its privileges are confined to that of the service account specified. |
There was a problem hiding this comment.
Suggested change
| OLM introduced a new feature that applies principle of attenuation to the operator being installed. The administrator can specify a service account with a set of privilege(s) granted to it. OLM will ensure that when an operator is installed its privileges are confined to that of the service account specified. | |
| OLM introduced a new feature that applies principle of attenuation to the operator being installed. The administrator can specify a service account with a set of privilege(s) granted to it. OLM will ensure that when an operator is installed its privileges are confined to that of the service account specified. | |
| As a result a `cluster-admin` can limit an Operator to a pre-defined set of RBAC rules. The Operator will not be able to do anything that is not explicitly permitted by those. This enables self-sufficient installation of Operators by non-`cluster-admin` users with a limited scope. |
|
/lgtm |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmesser, ecordell, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-aws-console-olm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.