Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1717636: Add relatedObjects to cluster operator status #960

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Bug 1717636: Add relatedObjects to cluster operator status #960

merged 1 commit into from
Aug 8, 2019

Conversation

dinhxuanvu
Copy link
Member

Signed-off-by: Vu Dinh [email protected]

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2019
@dinhxuanvu
Copy link
Member Author

/retest

1 similar comment
@dinhxuanvu
Copy link
Member Author

/retest

@ecordell ecordell changed the title bug(1717636): Add relatedObjects to cluster operator status bug 1717636: Add relatedObjects to cluster operator status Jul 23, 2019
@ecordell ecordell changed the title bug 1717636: Add relatedObjects to cluster operator status Bug 1717636: Add relatedObjects to cluster operator status Jul 23, 2019
@dinhxuanvu
Copy link
Member Author

/retest

2 similar comments
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/960/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-olm/2567/artifacts/e2e-aws-olm/must-gather/must-gather.log

I don’t see the PackageManifests being collected, but I see everything else. Any ideas?

@dinhxuanvu
Copy link
Member Author

We actually never create cluster operator for package server.

@dinhxuanvu dinhxuanvu force-pushed the relatedobjects branch 2 times, most recently from b66f038 to ac5dd0a Compare July 31, 2019 14:37
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu dinhxuanvu force-pushed the relatedobjects branch 2 times, most recently from 32e6421 to cdc7a9c Compare August 1, 2019 08:34
@dinhxuanvu
Copy link
Member Author

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

ecordell commented Aug 6, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@ecordell
Copy link
Member

ecordell commented Aug 6, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 6, 2019
@ecordell ecordell changed the title Bug 1717636: Add relatedObjects to cluster operator status Bug 1738203: Add relatedObjects to cluster operator status Aug 6, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 6, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1738203: Add relatedObjects to cluster operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 6, 2019
@ecordell ecordell changed the title Bug 1738203: Add relatedObjects to cluster operator status Bug 1717636: Add relatedObjects to cluster operator status Aug 6, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 6, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1717636: Add relatedObjects to cluster operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 6, 2019
@ecordell
Copy link
Member

ecordell commented Aug 6, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@ecordell: This pull request references a valid Bugzilla bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member Author

/retest

2 similar comments
@ecordell
Copy link
Member

ecordell commented Aug 7, 2019

/retest

@dinhxuanvu
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 586e941 into operator-framework:master Aug 8, 2019
@openshift-ci-robot
Copy link
Collaborator

@dinhxuanvu: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1717636: Add relatedObjects to cluster operator status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alecmerdler pushed a commit to alecmerdler/operator-lifecycle-manager that referenced this pull request Aug 14, 2019
@openshift-merge-robot @alecmerdler
Merge pull request operator-framework#960 from dinhxuanvu/relatedobjects
07fa728 
Bug 1717636: Add relatedObjects to cluster operator status
@dinhxuanvu
Copy link
Member Author

/cherry-pick release-4.1

@openshift-cherrypick-robot
Copy link

@dinhxuanvu: only operator-framework org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpeeler
Copy link

jpeeler commented Aug 19, 2019

/cherry-pick release-4.1

@openshift-cherrypick-robot
Copy link

@jpeeler: only operator-framework org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member Author

/cherry-pick release-4.1

@openshift-cherrypick-robot
Copy link

@dinhxuanvu: only operator-framework org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member Author

/cherry-pick release-4.1

@openshift-cherrypick-robot
Copy link

@dinhxuanvu: only operator-framework org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@njhale
Copy link
Member

njhale commented Aug 21, 2019

/cherry-pick release-4.1

@openshift-cherrypick-robot
Copy link

@njhale: #960 failed to apply on top of branch "release-4.1":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	cmd/catalog/main.go
M	cmd/olm/main.go
M	pkg/lib/operatorstatus/status.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/lib/operatorstatus/status.go
CONFLICT (content): Merge conflict in pkg/lib/operatorstatus/status.go
Auto-merging cmd/olm/main.go
CONFLICT (content): Merge conflict in cmd/olm/main.go
Auto-merging cmd/catalog/main.go
CONFLICT (content): Merge conflict in cmd/catalog/main.go
Patch failed at 0001 bug(1717636): Add relatedObjects to cluster operator status

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dinhxuanvu @ecordell @openshift-ci-robot @openshift-cherrypick-robot @jpeeler @njhale @openshift-merge-robot