Add Subscription InstallPlan Status #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
approved
njhale
force-pushed
the
sub-ips
branch
6 times, most recently
from
ff021fc to
078d75c
Compare
- Add Subscription InstallPlan status conditions - Add better condition getters/setters to InstallPlan status - Add hashstructure set tag to Subscription condition - Update internal version types to match
Add Subscription InstallPlan states and transition functions.
- Add Subscription InstallPlan status reconciler - Simplify Subscription catalog health reconciler transition loop conditions
- Add InstallPlan status reconciler to Subscription Syncer - Add InstallPlan Informer option to Subscription Syncer config - Plumb now function through transitionInstallPlanState(...)
njhale
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
ecordell
reviewed
Jun 26, 2019
| @@ -96,6 +125,11 @@ func (c *catalogHealthReconciler) catalogHealth(namespace string) ([]v1alpha1.Su | |||
| catalogs = append(catalogs, globals...) | |||
| } | |||
|
|
|||
| // Sort to ensure ordering | |||
| sort.Slice(catalogs, func(i, j int) bool { | |||
There was a problem hiding this comment.
we only really need this for testing, right? is there any way we can just sort for tests and not for prod?
ecordell
reviewed
Jun 26, 2019
| err = sync(s.Subscription()) | ||
| } | ||
| // installPlanReconciler reconciles InstallPlan status for Subscriptions. | ||
| type installPlanReconciler struct { |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Subscription status conditions for referenced InstallPlans.
Conditions added:
SubscriptionInstallPlanMissingSubscriptionInstallPlanPendingSubscriptionInstallPlanFailed