-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(proposal) Add user defined service account #880
(proposal) Add user defined service account #880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The only thing I'm thinking is that we may want to go ahead and use the serviceaccount for deploying the operator as well (deployment, etc). I don't see any reason not to, and it may help with other features in the future. But otherwise this looks good!
Sounds good to me! |
/refresh |
Put forth a proposal for the following story: As a cluster administrator, I should be able to require that all operator installs and upgrades be and run under a ServiceAccount, so that I can ensure no user can install an operator with greater permissions than their own.
089cd5f
to
51ec58d
Compare
I added this to the scope. @ecordell |
/test e2e-aws-console-olm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Put forth a proposal for the following story:
As a cluster administrator, I should be able to require that all
operator installs and upgrades be and run under a ServiceAccount,
so that I can ensure no user can install an operator with
greater permissions than their own.