Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(proposal) Add user defined service account #880

Merged

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented May 31, 2019

Put forth a proposal for the following story:
As a cluster administrator, I should be able to require that all
operator installs and upgrades be and run under a ServiceAccount,
so that I can ensure no user can install an operator with
greater permissions than their own.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 31, 2019
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The only thing I'm thinking is that we may want to go ahead and use the serviceaccount for deploying the operator as well (deployment, etc). I don't see any reason not to, and it may help with other features in the future. But otherwise this looks good!

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Jun 3, 2019

The only thing I'm thinking is that we may want to go ahead and use the serviceaccount for deploying the operator as well (deployment, etc). I don't see any reason not to, and it may help with other features in the future. But otherwise this looks good!

Sounds good to me!

@ecordell
Copy link
Member

ecordell commented Jun 7, 2019

/refresh
/retest

Put forth a proposal for the following story:
As a cluster administrator, I should be able to require that all
operator installs and upgrades be and run under a ServiceAccount,
so that I can ensure no user can install an operator with
greater permissions than their own.
@tkashem tkashem force-pushed the operator-group-sa branch from 089cd5f to 51ec58d Compare June 10, 2019 15:03
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2019
@tkashem
Copy link
Collaborator Author

tkashem commented Jun 10, 2019

/lgtm

The only thing I'm thinking is that we may want to go ahead and use the serviceaccount for deploying the operator as well (deployment, etc). I don't see any reason not to, and it may help with other features in the future. But otherwise this looks good!

I added this to the scope. @ecordell

@tkashem
Copy link
Collaborator Author

tkashem commented Jun 10, 2019

/test e2e-aws-console-olm

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 83fd607 into operator-framework:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants