Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Global Catalog Namespace for OpenShift #871

Merged

Conversation

alecmerdler
Copy link
Member

Description

Changes the -namespace and -global-namespace flags for catalog-operator and packageserver respectively. This allows creating Subscriptions directly to CatalogSources in the openshift-marketplace namespace without the indirection of creating a CatalogSourceConfig.

Addresses https://jira.coreos.com/browse/OLM-1080
Unblocks https://jira.coreos.com/browse/MKTPLC-367

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2019
@alecmerdler alecmerdler requested a review from njhale May 24, 2019 14:07
@alecmerdler
Copy link
Member Author

@njhale Do you foresee any issues with this change?

@njhale
Copy link
Member

njhale commented May 24, 2019

@njhale Do you foresee any issues with this change?

@alecmerdler I may be wrong, but if marketplace is still using CatalogSources for storage in that namespace, couldn't they be resolved over for any Subscription?

@ecordell
Copy link
Member

I thought what we wanted to do was have a new global namespace, that OLM and marketplace would both read/write from. I think we may have issues with the caching the marketplace does if we just point OLM to the marketplace namespace.

@ecordell
Copy link
Member

Just discussed with marketplace and it sounds like this will be fine!

@ecordell
Copy link
Member

/lgtm

@tkashem
Copy link
Collaborator

tkashem commented May 30, 2019

lgtm

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2019
@jpeeler
Copy link

jpeeler commented Jun 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, ecordell, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alecmerdler,ecordell,jpeeler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants