-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Global Catalog Namespace for OpenShift #871
Change Global Catalog Namespace for OpenShift #871
Conversation
@njhale Do you foresee any issues with this change? |
@alecmerdler I may be wrong, but if marketplace is still using |
I thought what we wanted to do was have a new global namespace, that OLM and marketplace would both read/write from. I think we may have issues with the caching the marketplace does if we just point OLM to the marketplace namespace. |
Just discussed with marketplace and it sounds like this will be fine! |
/lgtm |
lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler, ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Changes the
-namespace
and-global-namespace
flags forcatalog-operator
andpackageserver
respectively. This allows creatingSubscriptions
directly toCatalogSources
in theopenshift-marketplace
namespace without the indirection of creating aCatalogSourceConfig
.Addresses https://jira.coreos.com/browse/OLM-1080
Unblocks https://jira.coreos.com/browse/MKTPLC-367