Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit): Remove leftover println causing excessive log in unit test #859

Merged

Conversation

dinhxuanvu
Copy link
Member

@dinhxuanvu dinhxuanvu commented May 15, 2019

Leftover debugging printlf statement in util_test causes excessive
logging in many unit tests.

Signed-off-by: Vu Dinh [email protected]

@dinhxuanvu dinhxuanvu requested a review from ecordell May 15, 2019 01:29
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2019
Leftover debugging printlf statement in util_test causes excessive
logging in many unit tests.

Signed-off-by: Vu Dinh <[email protected]>
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@ecordell
Copy link
Member

/refresh

@ecordell
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member Author

/test e2e-aws-olm

@openshift-merge-robot openshift-merge-robot merged commit 5a87338 into operator-framework:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants