fix(operatorgroup): No targetNamespaces matched namespace selector #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
dinhxuanvu
force-pushed
the
op-ns
branch
6 times, most recently
from
693871f to
4c1f449
Compare
openshift-ci-robot
added
size/S
|
/retest |
ecordell
reviewed
May 9, 2019
openshift-ci-robot
added
size/XS
dinhxuanvu
changed the title
|
/test unit |
|
/retest |
|
/hold holding until master is open for 4.2 😢 |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@dinhxuanvu can you find an appropriate test to add a case for this state? otherwise it LGTM :) |
openshift-ci-robot
removed
the
size/XS
openshift-ci-robot
added
the
size/M
If no namespaces are matched selector in operatorgroup, CSV should have a failure status to indicate OperatorGroup NoTargetNamspaces. Also, a warning message for no-matched namespaces is added for visibility. Signed-off-by: Vu Dinh <[email protected]>
|
@ecordell Unit test case is added. Ready for final review. |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no namespaces are matched selector in operatorgroup, CSV should have a failure
status to indicate OperatorGroup NoTargetNamspaces. Also, a warning message for
no-matched namespaces is added for visibility.
Signed-off-by: Vu Dinh [email protected]