Add node-selector annotation to namespace #824
Conversation
|
@ravisantoshgudimetla: GitHub didn't allow me to request PR reviews from the following users: deads2k, sjenning. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
| @@ -6,3 +6,5 @@ metadata: | |||
| name: openshift-operator-lifecycle-manager | |||
| labels: | |||
| openshift.io/run-level: "1" | |||
| annotations: | |||
| openshift.io/node-selector: "" | |||
There was a problem hiding this comment.
@ecordell do we need to update every namespace.yaml for all releases?
|
/retest |
|
/test e2e-aws-olm |
1 similar comment
|
/test e2e-aws-olm |
|
/lgtm we'll follow up with changes to the templates so that this won't get added to upstream releases |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
@ravisantoshgudimetla: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Why this change?
When openshift/cluster-kube-apiserver-operator#394 merges, all the pods running openshift cluster will have a defaultNodeSelector if it has been set by cluster-admin including pods running in
openshift-*namespace. The main advantage of having that feature is in a multi-tenant environment, any new project created can be steered towards compute nodes(non-master nodes).What should I do?
If you think, the pods in your namespace shouldn't have defaultNodeSelector set, please review this PR. If not feel free to close this. The annotation added as part of this PR lets all the pods created within your project to not have the defaultNodeSelector set.
/cc @deads2k @sjenning