Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modules #805

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Fix modules #805

merged 3 commits into from
Apr 9, 2019

Conversation

njhale
Copy link
Member

@njhale njhale commented Apr 9, 2019

Re-pins kube dependencies to release-1.12 as per @jpeeler 's advice. This fixes OLM build and vendor.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2019
@njhale njhale requested review from ecordell and removed request for smarterclayton April 9, 2019 13:31
@ecordell
Copy link
Member

ecordell commented Apr 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b853cc5 into operator-framework:master Apr 9, 2019
@jpeeler jpeeler mentioned this pull request Apr 9, 2019
Closed
@njhale njhale mentioned this pull request Apr 9, 2019
Closed
@njhale njhale deleted the fix-modules branch September 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njhale @ecordell @openshift-ci-robot @openshift-merge-robot