clusteroperator: Report when OLM reaches "level" and check syncs #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
/test unit |
|
/retest |
ecordell
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
/lgtm
Thanks for getting us up to code, @smarterclayton
We should have something similar for catalog-operator; we'll need a new top-level clusterversion for reporting that.
I'll put something on the backlog to get better reporting of progressing. Sync success rate doesn't tell you much.
openshift-ci-robot
added
lgtm
|
/retest |
|
Looks like a legit failure /lgtm cancel |
I think these are the errors within the window of the test failing, but I can't see anything obvious |
alecmerdler
reviewed
Mar 12, 2019
smarterclayton
force-pushed
the
report_level_status
branch
from
0cf9ff6 to
cc76831
Compare
|
This is really wierd, the error is consistent in this PR. Trying to spot what I changed - I might have slowed the sync loop down such that we're now flaking more (would be my first guess). Have we seen this test flake before? |
smarterclayton
force-pushed
the
report_level_status
branch
from
cc76831 to
012ff64
Compare
|
Hrm, error also happened in https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/750/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-olm/1225/ So I think that flake is not this PR, but this PR might cause it to happen more frequently. |
|
/retest |
1 similar comment
|
/retest |
|
I have a pretty good idea of what's causing the flakes with |
|
#758 opened - should help out some. |
|
/retest |
Cluster operators are expected to report the version of the payload they are included in once they are "deployed", and also to keep the cluster operator object created. Have the OLM operator keep CO up to date, report the payload version once it hits available, and use the count of successful syncs from the queueInformers as a probalistic measurement of "available" (i.e. is the operator able to retire syncs). A future change should add a "health over time" metric or a "has successfully synced all InstallPlans at least once" metric to replace the current estimation.
ecordell
force-pushed
the
report_level_status
branch
from
012ff64 to
1c10730
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
ecordell
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster operators are expected to report the version of the payload
they are included in once they are "deployed", and also to keep the
cluster operator object created. Have the OLM operator keep CO up
to date, report the payload version once it hits available, and use
the count of successful syncs from the queueInformers as a probalistic
measurement of "available" (i.e. is the operator able to retire syncs).
A future change should add a "health over time" metric or a "has
successfully synced all InstallPlans at least once" metric to replace
the current estimation.