Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(manifests): regenerate manifests to include new anyOf validation #744

Merged

Conversation

njhale
Copy link
Member

@njhale njhale commented Mar 7, 2019

Regenerates manifests to include the new anyOf validation for OperatorGroup LabelSelectors.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2019
@@ -7,21 +7,21 @@ writeStatusName: '""'
olm:
replicaCount: 1
image:
ref: quay.io/openshift/origin-operator-lifecycle-manager:latest
ref: quay.io/coreos/olm@sha256:995a181839f301585a0e115c083619b6d73812c58a8444d7b13b8e407010325f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this as the openshift one until we've published a new upstream image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed when the next release is cut

@njhale
Copy link
Member Author

njhale commented Mar 7, 2019

/test unit

@njhale
Copy link
Member Author

njhale commented Mar 7, 2019

/retest

@njhale njhale closed this Mar 7, 2019
@njhale njhale reopened this Mar 7, 2019
@njhale njhale force-pushed the update-group-manifests branch from f5e1d21 to efe900e Compare March 7, 2019 18:27
@ecordell
Copy link
Member

ecordell commented Mar 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
Allows for empty LabelSelectors to accommodate anyOf validation.
@njhale njhale force-pushed the update-group-manifests branch from efe900e to 0c5d55e Compare March 7, 2019 18:58
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@ecordell
Copy link
Member

ecordell commented Mar 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
Regenerates manifests using `make release` to include new OperatorGroup
anyOf validation.
@njhale njhale force-pushed the update-group-manifests branch from 0c5d55e to 20739d3 Compare March 7, 2019 20:24
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@jpeeler
Copy link

jpeeler commented Mar 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, jpeeler, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,jpeeler,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member Author

njhale commented Mar 7, 2019

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Mar 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a9736f0 into operator-framework:master Mar 7, 2019
@njhale njhale deleted the update-group-manifests branch September 30, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants