fix(olm): properly detect cluster operator API #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
jpeeler
added
do-not-merge/work-in-progress
|
Will test this further while doing other installer work. |
njhale
reviewed
Feb 13, 2019
This was referenced Feb 13, 2019
jpeeler
force-pushed
the
clusteroperator-discovery
branch
from
2d09672 to
128a431
Compare
openshift-ci-robot
added
approved
|
/retest |
jpeeler
force-pushed
the
clusteroperator-discovery
branch
from
128a431 to
13066e9
Compare
This was causing vanilla upstream to crash due to attempting to write to a not present API. Also, disable writing operator status by default since it's OpenShift specific.
jpeeler
force-pushed
the
clusteroperator-discovery
branch
from
13066e9 to
059498b
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jpeeler
removed
the
do-not-merge/work-in-progress
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…r-discovery fix(olm): properly detect cluster operator API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing vanilla upstream to crash due to attempting to write to
a not present API.