feat(catalogsource): allow grpc source types that don't require an image #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
approved
openshift-ci-robot
added
size/L
njhale
force-pushed
the
grpc-address
branch
3 times, most recently
from
4d923c1 to
6868037
Compare
openshift-ci-robot
added
size/XL
njhale
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
jpeeler
reviewed
Feb 14, 2019
| // +Optional | ||
| ConfigMap string `json:"configMap,omitempty"` | ||
|
|
||
| // Address an address that OLM can use to connect to a pre-existing registry. |
There was a problem hiding this comment.
nit: "Address is a host that OLM...". Since one e2e failed, maybe it's worth fixing.
jpeeler
reviewed
Feb 14, 2019
| @@ -664,7 +666,7 @@ func (o *Operator) ensureResolverSources(logger *logrus.Entry, namespace string) | |||
| logger.WithField("clientState", client.Conn.GetState()).Debug("source") | |||
| if client.Conn.GetState() == connectivity.TransientFailure { | |||
| logger.WithField("clientState", client.Conn.GetState()).Debug("waiting for connection") | |||
| ctx, _ := context.WithTimeout(context.TODO(), 5*time.Second) | |||
| ctx, _ := context.WithTimeout(context.TODO(), 2*time.Second) | |||
There was a problem hiding this comment.
I assume that was an arbitrary time out.
There was a problem hiding this comment.
I was playing with the timeouts - I'm changing it back, thanks for pointing it out. Yeah it's arbitrary. I really hope over the next sprint we can encapsulate connection logic into a separate module (I'm thinking a ConnectionManager in a separate thread).
|
/lgtm |
|
/retest |
instead, they provide an address directly. OLM will not have visibility into the resources required for running the grpc catalog for this case, but will still connect and health check.
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
feat(catalogsource): allow grpc source types that don't require an image
ecordell
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead, they provide an address directly. OLM will not have visibility
into the resources required for running the grpc catalog for this case,
but will still connect and health check.
Replaces #684