fix(reconciler): set command in pod spec of registry images #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
|
/test e2e-aws-olm |
|
/retest |
openshift-ci-robot
added
size/M
|
/retest |
openshift-ci-robot
added
size/L
|
/retest |
njhale
reviewed
Jan 29, 2019
| } | ||
|
|
||
| if err := o.updateSubscriptionSetInstallPlanState(namespace, subs, installplanReference); err != nil { | ||
| logger.WithError(err).Debug("error ensuring subscription installplan state") | ||
| if err := o.updateSubscriptionStatus(namespace, subs, nil); err != nil { |
There was a problem hiding this comment.
What case does this cover? It's not immediately apparent to me.
There was a problem hiding this comment.
this is ensuring that subscriptions get their last update time updated whenever we've fully processed them, so that on a resync we see the time as newer and don't process when we don't need to
|
/test e2e-aws |
resolved. This solves an issue where duplicate installplans are sometimes created. It also fixes an issue where a new installplan may be created if the catalog operator restarts
|
/test e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
fix(reconciler): set command in pod spec of registry images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a part of #666 but I'm seeing weird issues with the CI, so I split it out into its own PR.