Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cm-reconciler): query for pods to overwrite by CatalogSource label #680

Conversation

njhale
Copy link
Member

@njhale njhale commented Jan 22, 2019

Removes additional label equality (olm.configMapResourceVersion) from query selector used to list existing pods for deletion when overwriting configmap registry pods.

Addresses ALM-877.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2019
@njhale njhale force-pushed the fix-registry-pod-overwrite branch from c34eb14 to eea2c2c Compare January 22, 2019 15:45
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@njhale
Copy link
Member Author

njhale commented Jan 22, 2019

/test e2e-aws-olm

@njhale njhale force-pushed the fix-registry-pod-overwrite branch from eea2c2c to 3709e25 Compare January 22, 2019 18:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2019
@njhale njhale force-pushed the fix-registry-pod-overwrite branch from 3709e25 to 63885cc Compare January 22, 2019 19:28
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2019
@njhale
Copy link
Member Author

njhale commented Jan 22, 2019

/test e2e-aws-olm

@njhale
Copy link
Member Author

njhale commented Jan 22, 2019

/retest

@njhale
Copy link
Member Author

njhale commented Jan 22, 2019

/test e2e-aws

@ecordell
Copy link
Member

/lgtm

@ecordell
Copy link
Member

/test e2e-aws

@njhale
Copy link
Member Author

njhale commented Jan 23, 2019

/retest

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alecmerdler,ecordell,njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 85363e8 into operator-framework:master Jan 23, 2019
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…d-overwrite

fix(cm-reconciler): query for pods to overwrite by CatalogSource label
@ecordell ecordell added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
@njhale njhale deleted the fix-registry-pod-overwrite branch September 30, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants