Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metering Operator to catalog #647

Merged

Conversation

EmilyM1
Copy link
Member

@EmilyM1 EmilyM1 commented Jan 3, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2019
@EmilyM1 EmilyM1 requested a review from chancez January 3, 2019 22:04
@EmilyM1 EmilyM1 force-pushed the add-metering-to-OLM branch from b4c2497 to a7f395a Compare January 3, 2019 22:11
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2019
alm-owner-metering: metering-operator
installModes:
- type: OwnNamespace
supported: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1285,7 +1285,7 @@ data:

containers:
- name: mongodb-enterprise-operator
image: quay.io/mongodb/mongodb-enterprise-operator:0.3
image: registry.connect.redhat.com/mongodb/enterprise-operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in your PR. Looks like you may have rebased incorrectly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't rebase

@EmilyM1 EmilyM1 force-pushed the add-metering-to-OLM branch from 97816d3 to a4c7a9e Compare January 4, 2019 23:46
@ecordell
Copy link
Member

ecordell commented Jan 5, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, EmilyM1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0f47789 into operator-framework:master Jan 5, 2019
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants