fix 1663113. Add component image ENV vars to cluster-logging-operator #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
@jcantrill if you expect these changes to be available immediately, please run: And then commit + push (otherwise you can wait until we make the next release) |
jcantrill
force-pushed
the
1663113_env_log_vars
branch
from
c0367bf to
52c4bde
Compare
openshift-ci-robot
added
size/M
jcantrill
force-pushed
the
1663113_env_log_vars
branch
from
52c4bde to
69ea928
Compare
|
can you also add the following role rules as part of this pr to address https://bugzilla.redhat.com/show_bug.cgi?id=1662397 ? |
fix 1662397. Add permissions to create shared-config roles and bindings
jcantrill
force-pushed
the
1663113_env_log_vars
branch
from
69ea928 to
1b2d4ed
Compare
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-olm |
|
/test e2e-aws |
|
/test e2e-aws-olm |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…log_vars fix 1663113. Add component image ENV vars to cluster-logging-operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=1663113
by adding in the proper ENV vars from the operator manifest