Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(olm): update CSV status properly #588

Closed
wants to merge 1 commit into from
Closed

fix(olm): update CSV status properly #588

wants to merge 1 commit into from

Conversation

jpeeler
Copy link

@jpeeler jpeeler commented Nov 28, 2018

This sets status after creation.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2018
@jpeeler
Copy link
Author

jpeeler commented Nov 28, 2018

Although this will fix the e2e, it may not be the best fix after all.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@jpeeler jpeeler closed this Nov 28, 2018
@ecordell ecordell reopened this Nov 28, 2018
@ecordell
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2018
@jpeeler
Copy link
Author

jpeeler commented Nov 28, 2018

/hold cancel
I just ran the unit tests locally and they passed (failed here).

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@jpeeler
Copy link
Author

jpeeler commented Nov 28, 2018

/retest

@ecordell
Copy link
Member

/test unit

@jpeeler
Copy link
Author

jpeeler commented Dec 3, 2018

/retest

@ecordell
Copy link
Member

ecordell commented Dec 5, 2018

/test e2e-aws-olm

@jpeeler jpeeler mentioned this pull request Dec 5, 2018
Merged
@jpeeler jpeeler force-pushed the operator-group-status-fix branch from df42877 to f7c3bd9 Compare December 5, 2018 21:29
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2018
njhale
njhale approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member

njhale commented Dec 5, 2018

/test unit

@openshift-ci-robot
Copy link
Collaborator

@jpeeler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm f7c3bd9 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpeeler
Copy link
Author

jpeeler commented Dec 6, 2018

This fix was included in #603.

@jpeeler jpeeler closed this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@ecordell ecordell

@njhale njhale

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpeeler @ecordell @openshift-ci-robot @njhale