feat(mocks): generate fakes and mocks in a container #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
jpeeler
reviewed
Nov 12, 2018
| @@ -0,0 +1,9 @@ | |||
| FROM golang:1.10 | |||
There was a problem hiding this comment.
Does this not work correctly with 1.11?
ecordell
reviewed
Nov 12, 2018
Makefile
Outdated
| @@ -117,26 +118,33 @@ codegen: | |||
| $(CODEGEN) all $(PKG)/pkg/package-server/client $(PKG)/pkg/package-server/apis "packagemanifest:v1alpha1" | |||
|
|
|||
| container-codegen: | |||
| docker build -t olm:codegen -f codegen.Dockerfile . | |||
| docker build -t olm:codegen -f mockgen.Dockerfile . | |||
There was a problem hiding this comment.
shouldn't this still be codegen.Dockerfile?
njhale
force-pushed
the
container-mockgen
branch
from
75cb86a to
0f8f406
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
feat(mocks): generate fakes and mocks in a container
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
container-mockgenmake rule for generating fakes and mocks in a container.