Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRD to "View" RBAC Role #551

Closed
wants to merge 1 commit into from

Conversation

alecmerdler
Copy link
Member

Description

When creating the "view" Role for instances of a custom resource, add the CRD itself so users can fetch the validation and additional printer columns.

Addresses https://jira.coreos.com/browse/ALM-785

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2018
@alecmerdler
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2018
@ecordell
Copy link
Member

ecordell commented Nov 5, 2018

This looks good, we should support apiservices as well! I'm about to push up a PR that adds the pluralname to apiservicedefinitions in the CSV so that we can construct the RBAC for it

@alecmerdler
Copy link
Member Author

@ecordell Is this blocked by #571?

@ecordell
Copy link
Member

Nope it should be good to go. We need a story in JIRA for the apiservices version of this, though.

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2018
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2018
@njhale njhale closed this Nov 20, 2018
@njhale njhale reopened this Nov 20, 2018
@njhale njhale closed this Nov 21, 2018
@njhale njhale reopened this Nov 21, 2018
@njhale njhale closed this Nov 26, 2018
@njhale njhale reopened this Nov 26, 2018
@njhale
Copy link
Member

njhale commented Nov 26, 2018

/test e2e-aws

1 similar comment
@njhale
Copy link
Member

njhale commented Nov 26, 2018

/test e2e-aws

@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2018
@njhale
Copy link
Member

njhale commented Dec 10, 2018

/retest

@openshift-ci-robot
Copy link
Collaborator

@alecmerdler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 8110d11 link /test e2e-aws-olm
ci/prow/images 8110d11 link /test images
ci/prow/e2e-aws 8110d11 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell
Copy link
Member

This is included in #618

@ecordell ecordell closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants