-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRD to "View" RBAC Role #551
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This looks good, we should support apiservices as well! I'm about to push up a PR that adds the pluralname to apiservicedefinitions in the CSV so that we can construct the RBAC for it |
Nope it should be good to go. We need a story in JIRA for the |
/lgtm |
/lgtm |
/test e2e-aws |
1 similar comment
/test e2e-aws |
New changes are detected. LGTM label has been removed. |
/retest |
@alecmerdler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is included in #618 |
Description
When creating the "view"
Role
for instances of a custom resource, add the CRD itself so users can fetch the validation and additional printer columns.Addresses https://jira.coreos.com/browse/ALM-785