Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AMQ logo to new brand standard #547

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Update AMQ logo to new brand standard #547

merged 1 commit into from
Nov 7, 2018

Conversation

rhamilto
Copy link
Contributor

@rhamilto rhamilto commented Nov 1, 2018

Red Hat brand created a new logo for AMQ.

Before:
download

After:
amq

cc: @alecmerdler, @SamiSousa

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2018
alecmerdler
alecmerdler approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2018
@alecmerdler
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@alecmerdler
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 1, 2018
@ecordell ecordell closed this Nov 2, 2018
@ecordell ecordell reopened this Nov 2, 2018
@rhamilto
Copy link
Contributor Author

rhamilto commented Nov 5, 2018

@alecmerdler, any idea why this hasn't merged?

@njhale njhale closed this Nov 5, 2018
@njhale njhale reopened this Nov 5, 2018
@njhale njhale closed this Nov 5, 2018
@njhale njhale reopened this Nov 5, 2018
@ecordell ecordell closed this Nov 6, 2018
@ecordell ecordell reopened this Nov 6, 2018
@ecordell
Copy link
Member

ecordell commented Nov 6, 2018

@rhamilto sorry about the notifications, we're working through some CI changes. We'll merge this as soon as we get them sorted

@ecordell ecordell closed this Nov 6, 2018
@ecordell ecordell reopened this Nov 6, 2018
@ecordell ecordell closed this Nov 6, 2018
@ecordell ecordell reopened this Nov 6, 2018
@openshift-ci-robot
Copy link
Collaborator

@rhamilto: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws afd5b7f link /test e2e-aws
ci/prow/e2e-aws-olm afd5b7f link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ecordell ecordell merged commit 88da44e into operator-framework:master Nov 7, 2018
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@ecordell
Merge pull request operator-framework#547 from rhamilto/amq-icon-update
2cc29c4 
Update AMQ logo to new brand standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhamilto @alecmerdler @openshift-ci-robot @ecordell @njhale