Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 30_14-imagestream.yaml formatting #500

Merged
merged 1 commit into from
Oct 5, 2018
Merged

fix 30_14-imagestream.yaml formatting #500

merged 1 commit into from
Oct 5, 2018

Conversation

mrogers950
Copy link
Contributor

This PR should fix the following bootkube failure:

Oct 05 15:11:59 dev-bootstrap bootkube.sh[3929]: F1005 15:11:59.158817       1 image.go:36] error: error loading update payload from "/": error loading manifests from /: err
or parsing 99_olm_30_14-imagestream.yaml: error parsing: error converting YAML to JSON: yaml: line 17: mapping values are not allowed in this context

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2018
@alecmerdler
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2018
alecmerdler
alecmerdler approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
@alecmerdler
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2018
@openshift-merge-robot openshift-merge-robot merged commit def4358 into operator-framework:master Oct 5, 2018
@abhinavdahiya abhinavdahiya mentioned this pull request Oct 5, 2018
Merged
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@openshift-merge-robot
Merge pull request operator-framework#500 from mrogers950/fix_imagest…
b4bf3d7 
…ream_yaml

fix 30_14-imagestream.yaml formatting
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrogers950 @alecmerdler @openshift-ci-robot @njhale @openshift-merge-robot